Repository navigation
Round of fixes for jbwapi - #102
Merged
Merged
Conversation
Contributor
|
Looks good! |
JasperGeurtz
pushed a commit
that referenced
this pull request
Nov 7, 2026
added 8 commits
November 7, 2026 19:22
JasperGeurtz
pushed a commit
that referenced
this pull request
Nov 7, 2026
… PR #102 fixes # Conflicts: # src/test/java/bwapi/GameTest.java
JasperGeurtz
force-pushed
the
all-cgpt-fixes
branch
from
November 7, 2026 18:27
b262747 to
944a99f
Compare
JasperGeurtz
pushed a commit
that referenced
this pull request
Nov 7, 2026
… PR #102 fixes # Conflicts: # src/test/java/bwapi/GameTest.java
JasperGeurtz
force-pushed
the
all-cgpt-fixes
branch
from
November 7, 2026 18:32
944a99f to
ca9a01d
Compare
… PR #102 fixes # Conflicts: # src/test/java/bwapi/GameTest.java
JasperGeurtz
force-pushed
the
all-cgpt-fixes
branch
from
November 7, 2026 18:36
ca9a01d to
810617e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several behavioral discrepancies and bugs in JBWAPI, found using ChatGPT.
Changes
BuildingPlacer
Game
getUnitsOnTile()to return units whose bounding boxes intersect the specified tile, rather than only units whose top-left tile matches it.getUnitsInRadius()to use unit-to-position distance instead of approximate center-to-center distance.setMap().Player
Unit
getUnitsInWeaponRange().canGather()to check the target unit's position.canUseTechUnit().UnitFilter
IsTransportfilter while retainingIsTransPortas a deprecated alias for backward compatibility.